Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(iast): add extra pyobject checks on is_text and new_pyobject_id #10883

Merged
merged 8 commits into from
Oct 2, 2024
Merged

chore(iast): add extra pyobject checks on is_text and new_pyobject_id #10883

merged 8 commits into from
Oct 2, 2024
+196 −3

Conversation

juanjux
Copy link
Collaborator

@juanjux juanjux commented Oct 1, 2024 •
edited by gnufede
Loading

Description

  • Add some health checks on the pointer received by is_text and new_pyobject_id.
  • On index_aspect, nullptr-check the args.
  • Add some more tests related with the above.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@juanjux
Add extra pyobject checks on is_text and new_pyobject_id
ef96c45 
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@juanjux juanjux added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Oct 1, 2024
@juanjux juanjux self-assigned this Oct 1, 2024
@juanjux juanjux requested a review from a team as a code owner October 1, 2024 14:42
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

CODEOWNERS have been resolved as:

ddtrace/appsec/_iast/_taint_tracking/tests/test_index_aspect.cpp        @DataDog/asm-python
ddtrace/appsec/_iast/_taint_tracking/tests/test_other.cpp               @DataDog/asm-python
ddtrace/appsec/_iast/_taint_tracking/Aspects/AspectIndex.cpp            @DataDog/asm-python
ddtrace/appsec/_iast/_taint_tracking/Utils/StringUtils.cpp              @DataDog/asm-python
ddtrace/appsec/_iast/_taint_tracking/Utils/StringUtils.h                @DataDog/asm-python
ddtrace/appsec/_iast/_taint_tracking/clean.sh                           @DataDog/asm-python
ddtrace/appsec/_iast/_taint_tracking/tests/test_stringutils.cpp         @DataDog/asm-python

@pr-commenter
Copy link

pr-commenter bot commented Oct 1, 2024 •
edited
Loading

Benchmarks

Benchmark execution time: 2024-10-02 14:36:23

Comparing candidate commit 56fccda in PR branch juanjux/extra-pyobject-checks with baseline commit afb6f2f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 371 metrics, 53 unstable metrics.

@juanjux
Update test
8fe204b 
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@juanjux juanjux enabled auto-merge (squash) October 2, 2024 10:02
@juanjux juanjux merged commit 099ab94 into main Oct 2, 2024
629 checks passed
@juanjux juanjux deleted the juanjux/extra-pyobject-checks branch October 2, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufede gnufede gnufede approved these changes

@avara1986 avara1986 avara1986 approved these changes

Assignees

@juanjux juanjux

Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juanjux @gnufede @avara1986